General: Merge one-pod mode settings into a single toggle#516
Merged
Conversation
Combine reaction one-pod mode (autoplay/autopause) and firmware NC-with-one-AirPod into one setting. The merged toggle always sets the app-local flag and additionally syncs the firmware NC setting via AAP when connected. Also remove redundant @OptIn(ExperimentalCoroutinesApi::class) annotations from tests, already covered by the global compiler opt-in flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The separate "Noise Cancellation with One AirPod" toggle (in the Noise Control section) has been merged into the existing "One pod mode" toggle (in the Reactions section). Toggling one-pod mode now also keeps noise cancellation active when wearing a single AirPod, on supported models.
Technical Context
NcOnePodSender(following theStemConfigSenderpattern) syncs the firmware NC setting from the profile on AAP connect/reconnect, so the setting is applied even if the user toggles it while disconnected.hasNcOneAirpod, so on NC-capable devices (Pro, Pro 2, Pro 3, Gen4 ANC) the toggle is usable even without autoplay/autopause enabled.